Make Python Offset GUI button work when guiding via acamd offsetgoal#390
Open
Make Python Offset GUI button work when guiding via acamd offsetgoal#390
Conversation
cfremling
added a commit
that referenced
this pull request
Feb 8, 2026
When applying target offsets, check if ACAM is currently guiding. If so, use acamd offsetgoal command instead of TCS PT offset to preserve guiding state. Changes in target_offset(): 1. Query ACAM acquire status to check if guiding 2. If guiding: send offsetgoal to acamd (converts arcsec to degrees) 3. If not guiding: fall back to TCS PT offset (original behavior) This prevents target offsets from interrupting the guiding loop, allowing smooth offset application while maintaining lock on the guide star. Merged from: #390 Original commit: 8fd1208 Make targetoffset guiding-safe via acamd offsetgoal Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This would make the Python Offset GUI button work when guiding (and also when not guiding) via sequencer using offsetgoal.
should be checked by Dave and tested on sky on a test branch before pulling into main. I'm not totally sure acamd offsetgoal is fully implemented/active